]> git.baikalelectronics.ru Git - kernel.git/commit
mtd: nand: fix shutdown/reboot for multi-chip systems
authorBrian Norris <computersforpeace@gmail.com>
Tue, 10 Nov 2015 00:37:28 +0000 (16:37 -0800)
committerBrian Norris <computersforpeace@gmail.com>
Mon, 16 Nov 2015 18:51:39 +0000 (10:51 -0800)
commit4c24d672891c42c34a62540a268425de20a840fe
tree1092260a136a112cb4ae4dc86a89a814b6c9b4d5
parentc48a8dad5b5784ea162f5d18285976a150d58f8d
mtd: nand: fix shutdown/reboot for multi-chip systems

If multiple NAND chips are registered to the same controller, then when
rebooting the system, the first one will grab the controller lock, while
the second will wait forever for the first one to release it. i.e., a
classic deadlock.

This problem was solved for a similar case (suspend/resume) back in
commit ea0df6053419 ("mtd: nand: fix multi-chip suspend problem"), and
the shutdown state really isn't much different for us, so rather than
adding a new special case to nand_get_device(), we can just overload the
FL_PM_SUSPENDED state.

Now, multiple chips can "get" the same controller lock (preventing
further I/O), while we still allow other chips to pass through
nand_shutdown().

Original report:
http://thread.gmane.org/gmane.linux.drivers.mtd/59726
http://lists.infradead.org/pipermail/linux-mtd/2015-July/059992.html

Fixes: 97c919889aa3 ("mtd: nand: added nand_shutdown")
Reported-by: Andrew E. Mileski <andrewm@isoar.ca>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Andrew E. Mileski <andrewm@isoar.ca>
Acked-by: Scott Branden <sbranden@broadcom.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
drivers/mtd/nand/nand_base.c