]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: qcom: Set card->owner to avoid warnings
authorStephan Gerhold <stephan@gerhold.net>
Thu, 20 Aug 2020 15:45:11 +0000 (17:45 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 21 Aug 2020 15:12:10 +0000 (16:12 +0100)
commit4c21cf5140a2b91a6fe7f36d2f0b692a22603eea
tree4dce2839cb18fb997e35712db2dfc87030d191ff
parent271f6187d9e3ae6e4efb21480b57e380ef410961
ASoC: qcom: Set card->owner to avoid warnings

On Linux 5.9-rc1 I get the following warning with apq8016-sbc:

WARNING: CPU: 2 PID: 69 at sound/core/init.c:207 snd_card_new+0x36c/0x3b0 [snd]
CPU: 2 PID: 69 Comm: kworker/2:1 Not tainted 5.9.0-rc1 #1
Workqueue: events deferred_probe_work_func
pc : snd_card_new+0x36c/0x3b0 [snd]
lr : snd_card_new+0xf4/0x3b0 [snd]
Call trace:
 snd_card_new+0x36c/0x3b0 [snd]
 snd_soc_bind_card+0x340/0x9a0 [snd_soc_core]
 snd_soc_register_card+0xf4/0x110 [snd_soc_core]
 devm_snd_soc_register_card+0x44/0xa0 [snd_soc_core]
 apq8016_sbc_platform_probe+0x11c/0x140 [snd_soc_apq8016_sbc]

This warning was introduced in
commit e40cc84cb933 ("ALSA: core: Warn on empty module").
It looks like we are supposed to set card->owner to THIS_MODULE.

Fix this for all the qcom ASoC drivers.

Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Fixes: 3f4b78cbc127 ("ASoC: qcom: Add Storm machine driver")
Fixes: 557768ac5b8d ("ASoC: qcom: add apq8016 sound card support")
Fixes: fd4a86002f7b ("ASoC: qcom: apq8096: Add db820c machine driver")
Fixes: cf67b894905f ("ASoC: qcom: add sdm845 sound card support")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20200820154511.203072-1-stephan@gerhold.net
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/apq8016_sbc.c
sound/soc/qcom/apq8096.c
sound/soc/qcom/sdm845.c
sound/soc/qcom/storm.c