]> git.baikalelectronics.ru Git - kernel.git/commit
efi: Move efifb_setup_from_dmi() prototype from arch headers
authorJavier Martinez Canillas <javierm@redhat.com>
Fri, 26 Nov 2021 00:13:32 +0000 (01:13 +0100)
committerArd Biesheuvel <ardb@kernel.org>
Mon, 13 Dec 2021 14:07:16 +0000 (15:07 +0100)
commit4bc5e64e6cf37007e436970024e5998ee0935651
tree362ba4a0a8252992d0e75295ded3d34c077d561f
parent1ff2fc02862d52e18fd3daabcfe840ec27e920a8
efi: Move efifb_setup_from_dmi() prototype from arch headers

Commit 8633ef82f101 ("drivers/firmware: consolidate EFI framebuffer setup
for all arches") made the Generic System Framebuffers (sysfb) driver able
to be built on non-x86 architectures.

But it left the efifb_setup_from_dmi() function prototype declaration in
the architecture specific headers. This could lead to the following
compiler warning as reported by the kernel test robot:

   drivers/firmware/efi/sysfb_efi.c:70:6: warning: no previous prototype for function 'efifb_setup_from_dmi' [-Wmissing-prototypes]
   void efifb_setup_from_dmi(struct screen_info *si, const char *opt)
        ^
   drivers/firmware/efi/sysfb_efi.c:70:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void efifb_setup_from_dmi(struct screen_info *si, const char *opt)

Fixes: 8633ef82f101 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
Reported-by: kernel test robot <lkp@intel.com>
Cc: <stable@vger.kernel.org> # 5.15.x
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20211126001333.555514-1-javierm@redhat.com
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
arch/arm/include/asm/efi.h
arch/arm64/include/asm/efi.h
arch/riscv/include/asm/efi.h
arch/x86/include/asm/efi.h
include/linux/efi.h