]> git.baikalelectronics.ru Git - kernel.git/commit
drivers/net/wan/hdlc_fr: Move the skb_headroom check out of fr_hard_header
authorXie He <xie.he.0141@gmail.com>
Wed, 7 Oct 2020 18:32:03 +0000 (11:32 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 10 Oct 2020 19:05:05 +0000 (12:05 -0700)
commit4b7fcb9e4472f1b333f7d9a68d205fc506037e96
treedb693470e851226ab41fb2131e0257d01c0ecabc
parent6a6485a261d7a4f1095e8911012424cb8e8fa6dd
drivers/net/wan/hdlc_fr: Move the skb_headroom check out of fr_hard_header

Move the skb_headroom check out of fr_hard_header and into pvc_xmit.
This has two benefits:

1. Originally we only do this check for skbs sent by users on Ethernet-
emulating PVC devices. After the change we do this check for skbs sent on
normal PVC devices, too.
(Also add a comment to make it clear that this is only a protection
against upper layers that don't take dev->needed_headroom into account.
Such upper layers should be rare and I believe they should be fixed.)

2. After the change we can simplify the parameter list of fr_hard_header.
We no longer need to use a pointer to pointers (skb_p) because we no
longer need to replace the skb inside fr_hard_header.

Cc: Krzysztof Halasa <khc@pm.waw.pl>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wan/hdlc_fr.c