]> git.baikalelectronics.ru Git - kernel.git/commit
net: rds: Fix possible null-pointer dereferences in rds_rdma_cm_event_handler_cmn()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 26 Jul 2019 14:17:05 +0000 (22:17 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 27 Jul 2019 20:58:12 +0000 (13:58 -0700)
commit4b4ad798f3e873c07747c53fdf734bbd024e04a4
tree22b6f6c1191df43be0b299e4b3c0110748e347b6
parent409e93375d14f8da174d351d0334e283873f0b25
net: rds: Fix possible null-pointer dereferences in rds_rdma_cm_event_handler_cmn()

In rds_rdma_cm_event_handler_cmn(), there are some if statements to
check whether conn is NULL, such as on lines 65, 96 and 112.
But conn is not checked before being used on line 108:
    trans->cm_connect_complete(conn, event);
and on lines 140-143:
    rdsdebug("DISCONNECT event - dropping connection "
            "%pI6c->%pI6c\n", &conn->c_laddr,
            &conn->c_faddr);
    rds_conn_drop(conn);

Thus, possible null-pointer dereferences may occur.

To fix these bugs, conn is checked before being used.

These bugs are found by a static analysis tool STCheck written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rds/rdma_transport.c