]> git.baikalelectronics.ru Git - kernel.git/commit
svm: Fix improper check when deactivate AVIC
authorSuthikulpanit, Suravee <Suravee.Suthikulpanit@amd.com>
Tue, 29 Jan 2019 08:09:46 +0000 (08:09 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 20 Feb 2019 21:48:22 +0000 (22:48 +0100)
commit4b3ca14466fa934cc62a3b4327ca905f25c084ab
tree9e02bbbdd97f4cc082e260ada9614b1ea431ad6c
parentc610a9ff6d6b7c2c26b76986d683c8658d1a30d1
svm: Fix improper check when deactivate AVIC

The function svm_refresh_apicv_exec_ctrl() always returning prematurely
as kvm_vcpu_apicv_active() always return false when calling from
the function arch/x86/kvm/x86.c:kvm_vcpu_deactivate_apicv().
This is because the apicv_active is set to false just before calling
refresh_apicv_exec_ctrl().

Also, we need to mark VMCB_AVIC bit as dirty instead of VMCB_INTR.

So, fix svm_refresh_apicv_exec_ctrl() to properly deactivate AVIC.

Fixes: 4e1dff42a82e ('KVM: SVM: Add irqchip_split() checks before enabling AVIC')
Cc: Radim Krčmář <rkrcmar@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/svm.c