]> git.baikalelectronics.ru Git - kernel.git/commit
can: mcp251xfd: mcp251xfd_handle_rxif_one(): fix wrong NULL pointer check
authorQinglang Miao <miaoqinglang@huawei.com>
Wed, 13 Jan 2021 07:31:00 +0000 (15:31 +0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 13 Jan 2021 21:16:16 +0000 (22:16 +0100)
commit4b29e834b2cc2f76a0edaad2921be21a68b00a1f
treebc8dc1ff72f6ae18831f4cbf0062f523788e5fb5
parented21c1c4efa5cfc6dea3926b6ee350228372ad2b
can: mcp251xfd: mcp251xfd_handle_rxif_one(): fix wrong NULL pointer check

If alloc_canfd_skb() returns NULL, 'cfg' is an uninitialized variable, so we
should check 'skb' rather than 'cfd' after calling alloc_canfd_skb(priv->ndev,
&cfd).

Fixes: 74ed7c9bd838 ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20210113073100.79552-1-miaoqinglang@huawei.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c