]> git.baikalelectronics.ru Git - kernel.git/commit
raid5: Retry R5_ReadNoMerge flag when hit a read error.
authorBian Yu <bianyu@kedacom.com>
Thu, 14 Nov 2013 04:16:17 +0000 (15:16 +1100)
committerNeilBrown <neilb@suse.de>
Tue, 19 Nov 2013 04:18:24 +0000 (15:18 +1100)
commit49d47f78f9a7c84bd7c2091c1b04e09fcb110048
tree0a4087a7fb9a26089e99592f87bc515bbe60e789
parent54c52e266044c75d47b52e49a723ecfcf2665245
raid5: Retry R5_ReadNoMerge flag when hit a read error.

Because of block layer merge, one bio fails will cause other bios
which belongs to the same request fails, so raid5_end_read_request
will record all these bios as badblocks.
If retry request with R5_ReadNoMerge flag to avoid bios merge,
badblocks can only record sector which is bad exactly.

test:
hdparm --yes-i-know-what-i-am-doing --make-bad-sector 300000 /dev/sdb
mdadm -C /dev/md0 -l5 -n3 /dev/sd[bcd] --assume-clean
mdadm /dev/md0 -f /dev/sdd
mdadm /dev/md0 -r /dev/sdd
mdadm --zero-superblock /dev/sdd
mdadm /dev/md0 -a /dev/sdd

1. Without this patch:
cat /sys/block/md0/md/rd*/bad_blocks
299776 256
299776 256

2. With this patch:
cat /sys/block/md0/md/rd*/bad_blocks
300000 8
300000 8

Signed-off-by: Bian Yu <bianyu@kedacom.com>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid5.c