]> git.baikalelectronics.ru Git - kernel.git/commit
PCI/MSI: Clear PCI_MSIX_FLAGS_MASKALL on error
authorThomas Gleixner <tglx@linutronix.de>
Tue, 14 Dec 2021 11:42:14 +0000 (12:42 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 14 Dec 2021 12:23:32 +0000 (13:23 +0100)
commit4924466e5cfe1e4e6e32a6d143ab1ea399bca0e7
tree2a0c49fe48a5a9c592f29c7525129dba20f63431
parentc709dbf52cef4d2a3647eb0646ab0afe4ba58fc2
PCI/MSI: Clear PCI_MSIX_FLAGS_MASKALL on error

PCI_MSIX_FLAGS_MASKALL is set in the MSI-X control register at MSI-X
interrupt setup time. It's cleared on success, but the error handling path
only clears the PCI_MSIX_FLAGS_ENABLE bit.

That's incorrect as the reset state of the PCI_MSIX_FLAGS_MASKALL bit is
zero. That can be observed via lspci:

        Capabilities: [b0] MSI-X: Enable- Count=67 Masked+

Clear the bit in the error path to restore the reset state.

Fixes: edee230a0d55 ("PCI/MSI: Enable and mask MSI-X early")
Reported-by: Stefan Roese <sr@denx.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Stefan Roese <sr@denx.de>
Cc: linux-pci@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Marek Vasut <marex@denx.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/87tufevoqx.ffs@tglx
drivers/pci/msi.c