]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/ftrace: Fix typo in mask of opcode
authorMichael Ellerman <mpe@ellerman.id.au>
Tue, 17 Jun 2014 06:15:33 +0000 (16:15 +1000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 24 Jun 2014 04:05:37 +0000 (14:05 +1000)
commit48c32f18beb4b35a5522d56cda765916ac5d9db5
tree06da7e39932d5b80cd704e6cd19c7ca9491efa8b
parent5bd7d31bebfbb3d4fdcbe63360f0e0d7634c1f5b
powerpc/ftrace: Fix typo in mask of opcode

In commit ddc9f5981, "Fix ABIv2 issues with __ftrace_make_call", Anton
changed the logic that checks for the expected code sequence when
patching a module.

We missed the typo in the mask, 0xffff00000 should be 0xffff0000, which
has the effect of making the test always true.

That makes it impossible to ftrace against modules, eg:

  Unexpected call sequence: 48000008 e8410018
  WARNING: at ../kernel/trace/ftrace.c:1638
  ftrace failed to modify [<d000000007cf001c>] rng_dev_open+0x1c/0x70 [rng_core]

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/kernel/ftrace.c