]> git.baikalelectronics.ru Git - kernel.git/commit
net: cpsw: do not register cpts twice
authorBenedikt Spranger <b.spranger@linutronix.de>
Sun, 16 Mar 2014 15:36:29 +0000 (16:36 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Mar 2014 02:17:32 +0000 (22:17 -0400)
commit48abc3ba1cfcfd897df757543474898b76a22f4f
treed4b9f15ca6428915e481abb6aaf9db7ae1c1cb82
parentfa85ee0ec0b7bbd77dd08ade2b52f683b6f6a7d0
net: cpsw: do not register cpts twice

commit e642ee62 (drivers: net: cpsw: fix for cpsw crash when build as modules)
moved cpts_register()/cpts_unregister() to  ndo_open()/ndo_stop(), but failed
to remove cpts_register in cpsw_probe() which leads to a double registration
and the following debug object splat.

[   18.991902] ODEBUG: init active (active state 0) object type: timer_list hint: delayed_work_timer_fn+0x0/0x2c
[   19.082249] [<c0059e80>] (init_timer_key) from [<c04965d4>] (cpts_register+0x1f0/0x2c4)
[   19.090642] [<c04965d4>] (cpts_register) from [<c04931dc>] (cpsw_ndo_open+0x780/0x81c)
[   19.098948] [<c04931dc>] (cpsw_ndo_open) from [<c0599c2c>] (__dev_open+0xb4/0x118)

Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/cpsw.c