]> git.baikalelectronics.ru Git - kernel.git/commit
target: Don't return success from module_init() if setup fails
authorRoland Dreier <roland@purestorage.com>
Wed, 31 Oct 2012 16:16:44 +0000 (09:16 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Thu, 1 Nov 2012 07:38:31 +0000 (00:38 -0700)
commit47a70f45898b62ddf6268ab920ab4c228a555b63
tree834a22aa519cb6b9cd28de32b750700a92c923c1
parent4dc0a9cf92ec3efeb1dddb67cb6f7431b87a335d
target: Don't return success from module_init() if setup fails

If the call to core_dev_release_virtual_lun0() fails, then nothing
sets ret to anything other than 0, so even though everything is
torn down and freed, target_core_init_configfs() will seem to succeed
and the module will be loaded.  Fix this by passing the return value
on up the chain.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_configfs.c