]> git.baikalelectronics.ru Git - kernel.git/commit
[NET]: Fix race in dev_close(). (Bug 9750)
authorMatti Linnanvuori <mattilinnanvuori@yahoo.com>
Wed, 13 Feb 2008 07:10:11 +0000 (23:10 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Feb 2008 07:11:16 +0000 (23:11 -0800)
commit4711abf1d03007883ae49a75aeb6940a09c757ec
tree4e60a1971f7705ea1837a3e5c1cb9b71c0bd7fa1
parent9503540bba334756dde9b8b530ae30e438f1239f
[NET]: Fix race in dev_close(). (Bug 9750)

There is a race in Linux kernel file net/core/dev.c, function dev_close.
The function calls function dev_deactivate, which calls function
dev_watchdog_down that deletes the watchdog timer. However, after that, a
driver can call netif_carrier_ok, which calls function
__netdev_watchdog_up that can add the watchdog timer again. Function
unregister_netdevice calls function dev_shutdown that traps the bug
!timer_pending(&dev->watchdog_timer). Moving dev_deactivate after
netif_running() has been cleared prevents function netif_carrier_on
from calling __netdev_watchdog_up and adding the watchdog timer again.

Signed-off-by: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c