]> git.baikalelectronics.ru Git - kernel.git/commit
net: enetc: fix destroyed phylink dereference during unbind
authorVladimir Oltean <vladimir.oltean@nxp.com>
Tue, 16 Feb 2021 10:16:28 +0000 (12:16 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Feb 2021 23:05:07 +0000 (15:05 -0800)
commit470574bf8a319a7519830eb7ad0cc06fa8ab6296
tree10275431dc38144426ef6e6823f027e02b21ce3c
parent6c592ef5c4f751cb71c74097a5e6d4b41a80c32e
net: enetc: fix destroyed phylink dereference during unbind

The following call path suggests that calling unregister_netdev on an
interface that is up will first bring it down.

enetc_pf_remove
-> unregister_netdev
   -> unregister_netdevice_queue
      -> unregister_netdevice_many
         -> dev_close_many
            -> __dev_close_many
               -> enetc_close
                  -> enetc_stop
                     -> phylink_stop

However, enetc first destroys the phylink instance, then calls
unregister_netdev. This is already dissimilar to the setup (and error
path teardown path) from enetc_pf_probe, but more than that, it is buggy
because it is invalid to call phylink_stop after phylink_destroy.

So let's first unregister the netdev (and let the .ndo_stop events
consume themselves), then destroy the phylink instance, then free the
netdev.

Fixes: 1913b4e50ae8 ("enetc: Migrate to PHYLINK and PCS_LYNX")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/enetc/enetc_pf.c