]> git.baikalelectronics.ru Git - kernel.git/commit
block: fix blk_stack_limits() regression due to lcm() change
authorMike Snitzer <snitzer@redhat.com>
Mon, 30 Mar 2015 17:39:09 +0000 (13:39 -0400)
committerJens Axboe <axboe@fb.com>
Tue, 31 Mar 2015 15:45:50 +0000 (09:45 -0600)
commit46b8a7997fa8e76ee7894cee3719f2a907e2c34a
tree81fb7a27d9d7803fe93745e1a3a1c5f984b8af97
parenta3296cc3fe121ed08bf7bc320cc777bd8dc8009c
block: fix blk_stack_limits() regression due to lcm() change

Linux 3.19 commit 7a541cd ("lib/lcm.c: lcm(n,0)=lcm(0,n) is 0, not n")
caused blk_stack_limits() to not properly stack queue_limits for stacked
devices (e.g. DM).

Fix this regression by establishing lcm_not_zero() and switching
blk_stack_limits() over to using it.

DM uses blk_set_stacking_limits() to establish the initial top-level
queue_limits that are then built up based on underlying devices' limits
using blk_stack_limits().  In the case of optimal_io_size (io_opt)
blk_set_stacking_limits() establishes a default value of 0.  With commit
7a541cd, lcm(0, n) is no longer n, which compromises proper stacking of
the underlying devices' io_opt.

Test:
$ modprobe scsi_debug dev_size_mb=10 num_tgts=1 opt_blks=1536
$ cat /sys/block/sde/queue/optimal_io_size
786432
$ dmsetup create node --table "0 100 linear /dev/sde 0"

Before this fix:
$ cat /sys/block/dm-5/queue/optimal_io_size
0

After this fix:
$ cat /sys/block/dm-5/queue/optimal_io_size
786432

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org # 3.19+
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-settings.c
include/linux/lcm.h
lib/lcm.c