]> git.baikalelectronics.ru Git - kernel.git/commit
perf top: Cleanup condition in perf_top__record_precise_ip()
authorNamhyung Kim <namhyung@kernel.org>
Fri, 11 Dec 2015 02:56:56 +0000 (11:56 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 11 Dec 2015 11:38:10 +0000 (08:38 -0300)
commit461e84b59d1be4d3c59e456a6e699bca3f0f90fc
tree8fb99a42d13d03812d5d7d6ce480d2c6cc215d51
parent95078a67a157daf61f2bfe3492aa62940359bab3
perf top: Cleanup condition in perf_top__record_precise_ip()

The 'he' cannot be NULL since it's caller hist_iter__top_callback() is
called only if iter->he is not NULL (see hist_entry_iter__add).  So
setting 'sym' before the condition to simplify the code.

Also make it clearer that the top->symbol_filter_entry check is only
meaningful on stdio mode (i.e. when use_browser is 0).

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1449802616-16170-4-git-send-email-namhyung@kernel.org
[ Complete the simplification replacing one more he->ms.sym with sym ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-top.c