]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: qcom: fix Kconfig for SC7280
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Wed, 9 Mar 2022 14:05:52 +0000 (14:05 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 9 Mar 2022 17:35:00 +0000 (17:35 +0000)
commit45c0d7c7f949136b143663f6c2881e2afb487634
tree69b53f3aa63617e6396be8e6bb3ac1f7b7f36896
parentde8c4e7ae72a5ba41d2c2a6dd1c9f37a5f54107a
ASoC: qcom: fix Kconfig for SC7280

select would force the symbol to value without checking the dependencies.
In this case selecting TX and RX MACROs directly without checking its
dependency on COMMON_CLK would break builds on platform which do no
set COMMON_CLK.
ex:
WARNING: unmet direct dependencies detected for SND_SOC_LPASS_RX_MACRO
  Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && COMMON_CLK [=n]
  Selected by [m]:
  - SND_SOC_SC7280 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] &&
 SND_SOC_QCOM [=m] && I2C [=y] && SOUNDWIRE [=m]

move select to imply which should enforce symbol to be set to 'n' if any
dependencies are not resolved.

Fixes: e411857c4340 ("ASoC: qcom: SC7280: Add machine driver")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220309140552.8065-1-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/Kconfig