]> git.baikalelectronics.ru Git - kernel.git/commit
netlink: don't forget to release a rhashtable_iter structure
authorAndrey Vagin <avagin@openvz.org>
Wed, 7 Sep 2016 04:31:17 +0000 (21:31 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 8 Sep 2016 00:29:38 +0000 (17:29 -0700)
commit459ad8dd9cf1ea483c04cb9b2f466b19154d78b8
treee0f0cf62857c34cadc995ed7846bd78c22e1b40f
parentec1d22243b404efd73c49a72807548af392af720
netlink: don't forget to release a rhashtable_iter structure

This bug was detected by kmemleak:
unreferenced object 0xffff8804269cc3c0 (size 64):
  comm "criu", pid 1042, jiffies 4294907360 (age 13.713s)
  hex dump (first 32 bytes):
    a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00  .2.,............
    00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de  ................
  backtrace:
    [<ffffffff8184dffa>] kmemleak_alloc+0x4a/0xa0
    [<ffffffff8124720f>] kmem_cache_alloc_trace+0x10f/0x280
    [<ffffffffa02864cc>] __netlink_diag_dump+0x26c/0x290 [netlink_diag]

v2: don't remove a reference on a rhashtable_iter structure to
    release it from netlink_diag_dump_done

Cc: Herbert Xu <herbert@gondor.apana.org.au>
Fixes: 735d41d60fbe ("netlink: Use rhashtable walk interface in diag dump")
Signed-off-by: Andrei Vagin <avagin@openvz.org>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/diag.c