]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/xive: Fix missing check of rc != OPAL_BUSY
authorMichael Ellerman <mpe@ellerman.id.au>
Thu, 20 Apr 2017 04:43:19 +0000 (14:43 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 20 Apr 2017 04:43:19 +0000 (14:43 +1000)
commit44ac81971bbd9fc7fb7b31882086917f5a85eb92
treeeb5ebabe7c22abe66386505bc597d27a0d2345fa
parent826fa0d9679ccfa7c2c2d55ad9397cfc13c53387
powerpc/xive: Fix missing check of rc != OPAL_BUSY

Dan Carpenter noticed that the code in __xive_native_disable_queue() has a for
loop with an unconditional break in the middle, which doesn't make a lot of
sense.

What the code's supposed to do is loop as long as OPAL says it's busy, if we get
any other return code, either success or failure, then we should break the loop.

So add the missing check.

Fixes: 4e9a0fc0cbad ("powerpc/xive: Native exploitation of the XIVE interrupt controller")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/sysdev/xive/native.c