]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Fix i915_ggtt_view_equal to handle rotation correctly
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 14 Oct 2015 14:51:06 +0000 (16:51 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 19 Nov 2015 15:42:06 +0000 (16:42 +0100)
commit4471225a7e9f2bc7477b6eedc3241cdaab6dcf8e
tree877f5af676aa9e9194f6c18a72d87b0a8340758d
parent7fbd668e6de9970f16555a794f6f2b7373bcbcda
drm/i915: Fix i915_ggtt_view_equal to handle rotation correctly

The rotated view depends upon the rotation paramters, but thus far we
didn't bother checking for those. This seems to have been an issue
ever since this was introduce in

commit aa7e99ca51cbb30d9a9310abc2e93d043281d949
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date:   Wed Dec 10 17:27:58 2014 +0000

    drm/i915: Infrastructure for supporting different GGTT views per object

But userspace is allowed to reuse framebuffer backing storage with
different framebuffers with different pixel formats/stride/whatever.
And e.g. SNA indeed does this. Hence we must check for all the
paramters to match, not just that it's rotated.

v2: intel_plane_obj_offset also needs to construct the full view, to
avoid fallout since they don't fully match.

Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1444834266-12689-3-git-send-email-daniel.vetter@ffwll.ch
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem_gtt.h
drivers/gpu/drm/i915/intel_display.c