]> git.baikalelectronics.ru Git - kernel.git/commit
[SCSI] zfcp: remove invalid reference to list iterator variable
authorJulia Lawall <Julia.Lawall@lip6.fr>
Tue, 4 Sep 2012 13:23:33 +0000 (15:23 +0200)
committerJames Bottomley <JBottomley@Parallels.com>
Mon, 24 Sep 2012 08:11:02 +0000 (12:11 +0400)
commit43bc9b9a6f1f87a108a99f21da2811851a476889
treedffc2877f9ebe9adcb69bf4821d976357098b11c
parent14059215f1175cce4246be4496b18881095cab57
[SCSI] zfcp: remove invalid reference to list iterator variable

If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  Replace port->adapter->scsi_host by
adapter->scsi_host.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Oversight in upsteam commit of v2.6.37
edc8beb6d67398fd99e09cc53ea92576ffc31b5e
"[SCSI] zfcp: Move ACL/CFDC code to zfcp_cfdc.c"
which merged the content of zfcp_erp_port_access_changed().

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Reviewed-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.37+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/s390/scsi/zfcp_cfdc.c