]> git.baikalelectronics.ru Git - kernel.git/commit
e100: fix length calculation in e100_get_regs_len
authorJacob Keller <jacob.e.keller@intel.com>
Wed, 8 Sep 2021 17:52:36 +0000 (10:52 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 27 Sep 2021 15:57:29 +0000 (08:57 -0700)
commit4329c8dc110b25d5f04ed20c6821bb60deff279f
tree93345f94f22eaa93722a46a17f2ba335f4aac7e5
parent3b1b6e82fb5e08e2cb355d7b2ee8644ec289de66
e100: fix length calculation in e100_get_regs_len

commit abf9b902059f ("e100: cleanup unneeded math") tried to simplify
e100_get_regs_len and remove a double 'divide and then multiply'
calculation that the e100_reg_regs_len function did.

This change broke the size calculation entirely as it failed to account
for the fact that the numbered registers are actually 4 bytes wide and
not 1 byte. This resulted in a significant under allocation of the
register buffer used by e100_get_regs.

Fix this by properly multiplying the register count by u32 first before
adding the size of the dump buffer.

Fixes: abf9b902059f ("e100: cleanup unneeded math")
Reported-by: Felicitas Hetzelt <felicitashetzelt@gmail.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/e100.c