]> git.baikalelectronics.ru Git - kernel.git/commit
blk-mq: insert request not through ->queue_rq into sw/scheduler queue
authorMing Lei <ming.lei@redhat.com>
Tue, 18 Aug 2020 09:07:28 +0000 (17:07 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 21 Aug 2020 23:09:22 +0000 (17:09 -0600)
commit42c184cd4082172c36b743dd767a0f9324f4df89
tree88cd539313001b0836078bb4d0fecf87f01b41f7
parentc04862664347562c26050ddb0c239bb2d723e9fc
blk-mq: insert request not through ->queue_rq into sw/scheduler queue

a570fcd7e0eb ("blk-mq: punt failed direct issue to dispatch list") supposed
to add request which has been through ->queue_rq() to the hw queue dispatch
list, however it adds request running out of budget or driver tag to hw queue
too. This way basically bypasses request merge, and causes too many request
dispatched to LLD, and system% is unnecessary increased.

Fixes this issue by adding request not through ->queue_rq into sw/scheduler
queue, and this way is safe because no ->queue_rq is called on this request
yet.

High %system can be observed on Azure storvsc device, and even soft lock
is observed. This patch reduces %system during heavy sequential IO,
meantime decreases soft lockup risk.

Fixes: a570fcd7e0eb ("blk-mq: punt failed direct issue to dispatch list")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c