]> git.baikalelectronics.ru Git - kernel.git/commit
tcp: less aggressive window probing on local congestion
authorYuchung Cheng <ycheng@google.com>
Wed, 16 Jan 2019 23:05:35 +0000 (15:05 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Jan 2019 23:12:26 +0000 (15:12 -0800)
commit42b6b5f557f747f19f3faa1289221eff7574aa56
tree3b264a3fb495fd15153869e2b129a0d8cad4c944
parentec4ae93b3a17f04015ed2aef07031cb2bd56d741
tcp: less aggressive window probing on local congestion

Previously when the sender fails to send (original) data packet or
window probes due to congestion in the local host (e.g. throttling
in qdisc), it'll retry within an RTO or two up to 500ms.

In low-RTT networks such as data-centers, RTO is often far below
the default minimum 200ms. Then local host congestion could trigger
a retry storm pouring gas to the fire. Worse yet, the probe counter
(icsk_probes_out) is not properly updated so the aggressive retry
may exceed the system limit (15 rounds) until the packet finally
slips through.

On such rare events, it's wise to retry more conservatively
(500ms) and update the stats properly to reflect these incidents
and follow the system limit. Note that this is consistent with
the behaviors when a keep-alive probe or RTO retry is dropped
due to local congestion.

Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_output.c