]> git.baikalelectronics.ru Git - kernel.git/commit
drm/doc: Drop misleading comment on drm_mode_config_cleanup
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 22 Oct 2019 16:37:17 +0000 (18:37 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 23 Oct 2019 09:00:41 +0000 (11:00 +0200)
commit42a84eb24296dcbe37feeb032e3f8ef556b30b51
tree2e84c9cc40f6a2585ef5f9922c430abbea081087
parentf09a44cfe40123a158fe97947d92a7c7869e6c60
drm/doc: Drop misleading comment on drm_mode_config_cleanup

This is not something we'll fix, because failing to clean up stuff (or
doing it in the wrong order) is a driver bug. The offending FIXME goes
all the way back to the original modeset merge.

We've added a WARN_ON in

commit b5481f320f8336dad30ef0893c87ac5713429a16
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Mon Dec 10 21:16:05 2012 +0100

    drm: reference framebuffers which are on the idr

including a comment blaming drivers on this. Right thing to do is most
likely drm_atomic_helper_shutdown plus making sure that
drm_mode_config_cleanup is not called too early (i.e. not in driver
unload, but only in the final drm_device release callback).

Cc: Mihail Atanassov <Mihail.Atanassov@arm.com>
Reported-by: Mihail Atanassov <Mihail.Atanassov@arm.com>
Reviewed-by: Mihail Atanassov <mihail.atanassov@arm.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191022163717.1064-1-daniel.vetter@ffwll.ch
drivers/gpu/drm/drm_mode_config.c