]> git.baikalelectronics.ru Git - kernel.git/commit
enetc: Fix tx rings bitmap iteration range, irq handling
authorClaudiu Manoil <claudiu.manoil@nxp.com>
Fri, 26 Jun 2020 16:17:29 +0000 (19:17 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Jun 2020 22:02:30 +0000 (15:02 -0700)
commit423f6301bbbcab438c952fb58fb80467b99247ee
tree03dbbeb08b233b0954b6245c1a10372ef746d0d2
parentda337006308c0074a18ca55fc8398f2766b965b6
enetc: Fix tx rings bitmap iteration range, irq handling

The rings bitmap of an interrupt vector encodes
which of the device's rings were assigned to that
interrupt vector.
Hence the iteration range of the tx rings bitmap
(for_each_set_bit()) should be the total number of
Tx rings of that netdevice instead of the number of
rings assigned to the interrupt vector.
Since there are 2 cores, and one interrupt vector for
each core, the number of rings asigned to an interrupt
vector is half the number of available rings.
The impact of this error is that the upper half of the
tx rings could still generate interrupts during napi
polling.

Fixes: 3d1def2125b5 ("enetc: Introduce basic PF and VF ENETC ethernet drivers")
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/enetc/enetc.c