]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: goto right label 'failed_mount3a'
authorJason Yan <yanaijie@huawei.com>
Fri, 16 Sep 2022 14:15:12 +0000 (22:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:41:54 +0000 (11:41 +0100)
commit41360fe66730a3edc0abb4ecccbd0941040472ca
tree31eef3c09be152da66e9cb577b23c9bef5f508c9
parentb8c26fb5cbf88dc16a055b225ab179538f7be41e
ext4: goto right label 'failed_mount3a'

[ Upstream commit 7e6afe685be109455dde989e77ffc614feababcb ]

Before these two branches neither loaded the journal nor created the
xattr cache. So the right label to goto is 'failed_mount3a'. Although
this did not cause any issues because the error handler validated if the
pointer is null. However this still made me confused when reading
the code. So it's still worth to modify to goto the right label.

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Link: https://lore.kernel.org/r/20220916141527.1012715-2-yanaijie@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Stable-dep-of: 89481b5fa8c0 ("ext4: correct inconsistent error msg in nojournal mode")
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/ext4/super.c