]> git.baikalelectronics.ru Git - kernel.git/commit
net/tls: fix sign extension issue when left shifting u16 value
authorColin Ian King <colin.king@canonical.com>
Tue, 30 Jun 2020 14:27:46 +0000 (15:27 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 30 Jun 2020 20:36:56 +0000 (13:36 -0700)
commit4135e450deb6a770d9d0f70a315f840d9b1b6add
tree28470429562a87d1f2bcf9ffbaf3beea9004518b
parentd58f14e9abe6a5dc904c2130b7a5daaef78eb57e
net/tls: fix sign extension issue when left shifting u16 value

Left shifting the u16 value promotes it to a int and then it
gets sign extended to a u64.  If len << 16 is greater than 0x7fffffff
then the upper bits get set to 1 because of the implicit sign extension.
Fix this by casting len to u64 before shifting it.

Addresses-Coverity: ("integer handling issues")
Fixes: 9e2c929d854f ("net/tls: Add asynchronous resync")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/tls.h