]> git.baikalelectronics.ru Git - kernel.git/commit
checkpatch: warn on unnecessary else after return or break
authorJoe Perches <joe@perches.com>
Wed, 6 Aug 2014 23:10:29 +0000 (16:10 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 7 Aug 2014 01:01:27 +0000 (18:01 -0700)
commit40ce032083003c9758d27cf29e6bcd866d23d1a1
tree472cf85c05fdcafe028e5b8140729327afcffeea
parent0e6ea51af46d03c89eed4f6ab316310f3ec168b0
checkpatch: warn on unnecessary else after return or break

Using an else following a break or return can unnecessarily indent code
blocks.

ie:
for (i = 0; i < 100; i++) {
int foo = bar();
if (foo < 1)
break;
else
usleep(1);
}

is generally better written as:

for (i = 0; i < 100; i++) {
int foo = bar();
if (foo < 1)
break;
usleep(1);
}

Warn when a bare else statement is preceded by a break or return
indented 1 tab more than the else.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
scripts/checkpatch.pl