]> git.baikalelectronics.ru Git - kernel.git/commit
can bcm: fix tx_setup off-by-one errors
authorOliver Hartkopp <socketcan@hartkopp.net>
Fri, 23 Sep 2011 08:23:47 +0000 (08:23 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Sep 2011 04:32:09 +0000 (00:32 -0400)
commit402d7ce5de1ac585306e6dfd68cd029cb79a8b40
tree4902665fccb2e69ecf1591302531a802b687a430
parentff5c91a995c4585943a62973fa192eee939adc75
can bcm: fix tx_setup off-by-one errors

This patch fixes two off-by-one errors that canceled each other out.
Checking for the same condition two times in bcm_tx_timeout_tsklet() reduced
the count of frames to be sent by one. This did not show up the first time
tx_setup is invoked as an additional frame is sent due to TX_ANNONCE.
Invoking a second tx_setup on the same item led to a reduced (by 1) number of
sent frames.

Reported-by: Andre Naujoks <nautsch@gmail.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/can/bcm.c