]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: Do not destroy invalid network devices
authorFlorian Fainelli <f.fainelli@gmail.com>
Wed, 8 Feb 2017 07:10:13 +0000 (23:10 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 Feb 2017 19:50:51 +0000 (14:50 -0500)
commit402be029945ca7281805f925b7c9213970add8c4
tree0799402b4792dada8d205c23346dbdeddc571bd5
parent37eb1afbe0b006e75a7446c08c78b2a69f20fa0b
net: dsa: Do not destroy invalid network devices

dsa_slave_create() can fail, and dsa_user_port_unapply() will properly check
for the network device not being NULL before attempting to destroy it. We were
not setting the slave network device as NULL if dsa_slave_create() failed, so
we would later on be calling dsa_slave_destroy() on a now free'd and
unitialized network device, causing crashes in dsa_slave_destroy().

Fixes: e292a926e6fa ("net: dsa: Add new binding implementation")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/dsa2.c