]> git.baikalelectronics.ru Git - kernel.git/commit
drm: Fix HDMI_STATIC_METADATA_TYPE1 constant
authorMario Kleiner <mario.kleiner.de@gmail.com>
Sun, 24 Jan 2021 04:40:10 +0000 (05:40 +0100)
committerSimon Ser <contact@emersion.fr>
Tue, 23 Feb 2021 18:26:43 +0000 (19:26 +0100)
commit400f18cced9de965a769611d6b76c78012aa687c
treedd6aeb4d843a731a5283b66b381405c8ec8fab19
parent54371665d0b7ec0ad61ac3b3e0613e8913b731dc
drm: Fix HDMI_STATIC_METADATA_TYPE1 constant

According to the CTA 861.G spec, HDMI_STATIC_METADATA_TYPE1 is
not 1, but zero, so fix this enum.

While this doesn't cause problems in the kernel yet, as the
constant isn't actively used by drivers yet, it did create
confusion while debugging HDR problems in yours truly, and
also potential bugs in userspace components, as the wrong
enum propagates to components, e.g., like it did already
into intel-gpu-tools (tests/kms_hdr.c) or is used as wrong
reference when writing future new userspace HDR components
like compositors.

Fixes: 122fbcdcaac2 ("drm: Add HDR source metadata property")
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Simon Ser <contact@emersion.fr>
Signed-off-by: Simon Ser <contact@emersion.fr>
Link: https://patchwork.freedesktop.org/patch/msgid/20210124044010.18678-1-mario.kleiner.de@gmail.com
include/linux/hdmi.h