]> git.baikalelectronics.ru Git - kernel.git/commit
vxlan: do not use RT_TOS for IPv6 flowlabel
authorMatthias May <matthias.may@westermo.com>
Fri, 5 Aug 2022 19:19:04 +0000 (21:19 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 10 Aug 2022 05:19:20 +0000 (22:19 -0700)
commit3f7d4fb9412cbdb898758fcc5956ea3029bb593d
tree746a09c1dffbc7bb70d7f69cc4456fed9b87ce70
parent99470e99d939716d39428acad37308fd5169a300
vxlan: do not use RT_TOS for IPv6 flowlabel

According to Guillaume Nault RT_TOS should never be used for IPv6.

Quote:
RT_TOS() is an old macro used to interprete IPv4 TOS as described in
the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
code, although, given the current state of the code, most of the
existing calls have no consequence.

But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
field to be interpreted the RFC 1349 way. There's no historical
compatibility to worry about.

Fixes: 29b37c5c9d93 ("vxlan: allow setting ipv6 traffic class")
Acked-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Matthias May <matthias.may@westermo.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/vxlan/vxlan_core.c