]> git.baikalelectronics.ru Git - kernel.git/commit
net/ncsi: check for error return from call to nla_put_u32
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Wed, 29 Dec 2021 03:21:18 +0000 (11:21 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 30 Dec 2021 01:53:24 +0000 (17:53 -0800)
commit3e33b3a5ce1eb0f8316817cecc867c590cd9ff9f
treee29ba093f8eecd7ecaac4103aba985787ec58e01
parentc0ff662bfde163c3d7c2dd3e851bd03ef60217fa
net/ncsi: check for error return from call to nla_put_u32

As we can see from the comment of the nla_put() that it could return
-EMSGSIZE if the tailroom of the skb is insufficient.
Therefore, it should be better to check the return value of the
nla_put_u32 and return the error code if error accurs.
Also, there are many other functions have the same problem, and if this
patch is correct, I will commit a new version to fix all.

Fixes: bd60efd10145 ("net/ncsi: Add generic netlink family")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20211229032118.1706294-1-jiasheng@iscas.ac.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ncsi/ncsi-netlink.c