]> git.baikalelectronics.ru Git - kernel.git/commit
net: sched: Fix hw_stats_type setting in pedit loop
authorPetr Machata <petrm@mellanox.com>
Wed, 18 Mar 2020 17:42:29 +0000 (19:42 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Mar 2020 23:52:04 +0000 (16:52 -0700)
commit3e24c529ceae0976cedfccad9dfae0872cf98c88
tree96af4c6d52d0f937a7ba909fd7f8f8df7d9bde0d
parent50a7be3c116941bb58af815f9b83855172e868f5
net: sched: Fix hw_stats_type setting in pedit loop

In the commit referenced below, hw_stats_type of an entry is set for every
entry that corresponds to a pedit action. However, the assignment is only
done after the entry pointer is bumped, and therefore could overwrite
memory outside of the entries array.

The reason for this positioning may have been that the current entry's
hw_stats_type is already set above, before the action-type dispatch.
However, if there are no more actions, the assignment is wrong. And if
there are, the next round of the for_each_action loop will make the
assignment before the action-type dispatch anyway.

Therefore fix this issue by simply reordering the two lines.

Fixes: 43ad7c238a48 ("net: sched: set the hw_stats_type in pedit loop")
Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_api.c