]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: pm8001: Fix use-after-free for aborted TMF sas_task
authorJohn Garry <john.garry@huawei.com>
Thu, 27 Jan 2022 13:12:51 +0000 (21:12 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 31 Jan 2022 21:40:07 +0000 (16:40 -0500)
commit3e17f540a0529ce49f3771ac3ba0c07ef3094943
tree5f150bf370460368c78f8e707b0d4a523028037d
parente176334ec4564e2788d80bd334f4b961ac9db15e
scsi: pm8001: Fix use-after-free for aborted TMF sas_task

Currently a use-after-free may occur if a TMF sas_task is aborted before we
handle the IO completion in mpi_ssp_completion(). The abort occurs due to
timeout.

When the timeout occurs, the SAS_TASK_STATE_ABORTED flag is set and the
sas_task is freed in pm8001_exec_internal_tmf_task().

However, if the I/O completion occurs later, the I/O completion still
thinks that the sas_task is available. Fix this by clearing the ccb->task
if the TMF times out - the I/O completion handler does nothing if this
pointer is cleared.

Link: https://lore.kernel.org/r/1643289172-165636-3-git-send-email-john.garry@huawei.com
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_sas.c