]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: qca8k: fix an endian bug in qca8k_get_ethtool_stats()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 9 Jun 2021 09:52:12 +0000 (12:52 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Jun 2021 21:10:38 +0000 (14:10 -0700)
commit3c3669c4ec956ff7ed27f515f258297f5a88d026
tree9f52540c7c797e6482a03676813c4fcdf8b98d33
parentc4caa0e1e09974059c71695c1a48729a73d6b130
net: dsa: qca8k: fix an endian bug in qca8k_get_ethtool_stats()

The "hi" variable is a u64 but the qca8k_read() writes to the top 32
bits of it.  That will work on little endian systems but it's a bit
subtle.  It's cleaner to make declare "hi" as a u32.  We will still need
to cast it when we shift it later on in the function but that's fine.

Fixes: 1965a47bad34 ("net: dsa: qca8k: check return value of read functions correctly")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/qca8k.c