]> git.baikalelectronics.ru Git - kernel.git/commit
ARM: dts: Use level interrupt for omap4 & 5 wlcore
authorTony Lindgren <tony@atomide.com>
Wed, 9 Oct 2019 22:11:27 +0000 (15:11 -0700)
committerTony Lindgren <tony@atomide.com>
Wed, 9 Oct 2019 22:11:27 +0000 (15:11 -0700)
commit3c191d61f79d7aff80009af0b034e71b139bc4e8
tree3baf4cd9509dc948f8e00aa7560399eeba66e2ee
parent83b4b06b7408ce798a220098fbeac6cb0a1db352
ARM: dts: Use level interrupt for omap4 & 5 wlcore

Commit cd7463abc4b6 ("ARM: dts: Improve omap l4per idling with wlcore edge
sensitive interrupt") changed wlcore interrupts to use edge interrupt based
on what's specified in the wl1835mod.pdf data sheet.

However, there are still cases where we can have lost interrupts as
described in omap_gpio_unidle(). And using a level interrupt instead of edge
interrupt helps as we avoid the check for untriggered GPIO interrupts in
omap_gpio_unidle().

And with commit 3d0054d3c925 ("gpio: gpio-omap: configure edge detection
for level IRQs for idle wakeup") GPIOs idle just fine with level interrupts.

Let's change omap4 and 5 wlcore users back to using level interrupt
instead of edge interrupt. Let's not change the others as I've only seen
this on omap4 and 5, probably because the other SoCs don't have l4per idle
independent of the CPUs.

Fixes: cd7463abc4b6 ("ARM: dts: Improve omap l4per idling with wlcore edge sensitive interrupt")
Depends-on: 3d0054d3c925 ("gpio: gpio-omap: configure edge detection for level IRQs for idle wakeup")
Cc: Anders Roxell <anders.roxell@linaro.org>
Cc: Eyal Reizer <eyalr@ti.com>
Cc: Guy Mishol <guym@ti.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/boot/dts/omap4-droid4-xt894.dts
arch/arm/boot/dts/omap4-panda-common.dtsi
arch/arm/boot/dts/omap4-sdp.dts
arch/arm/boot/dts/omap4-var-som-om44-wlan.dtsi
arch/arm/boot/dts/omap5-board-common.dtsi