]> git.baikalelectronics.ru Git - kernel.git/commit
IB/qib: Fix clang confusion of NULL pointer comparison
authorJason Gunthorpe <jgg@nvidia.com>
Mon, 13 Sep 2021 19:25:56 +0000 (16:25 -0300)
committerJason Gunthorpe <jgg@nvidia.com>
Mon, 13 Sep 2021 19:28:39 +0000 (16:28 -0300)
commit3b78d5747440c415c1eb060d65a2c504881690bc
treef02df3515e70a2a0c04029b0f8c8ef37ecbc6a70
parent4ce062870c70d404088bf50de34ea03772413b4e
IB/qib: Fix clang confusion of NULL pointer comparison

clang becomes confused due to the comparison to NULL in a integer constant
expression context:

 >> drivers/infiniband/hw/qib/qib_sysfs.c:413:1: error: static_assert expression is not an integral constant expression
    QIB_DIAGC_ATTR(rc_resends);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/infiniband/hw/qib/qib_sysfs.c:406:16: note: expanded from macro 'QIB_DIAGC_ATTR'
            static_assert(&((struct qib_ibport *)0)->rvp.n_##N != (u64 *)NULL);    \

Nathan found __same_type that solves this problem nicely, so use it instead.

Reported-by: kernel test robot <lkp@intel.com>
Suggested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/qib/qib_sysfs.c