]> git.baikalelectronics.ru Git - kernel.git/commit
NFS: direct.c: Fix memory leak of dreq when nfs_get_lock_context fails
authorMisono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Wed, 28 Aug 2019 08:01:22 +0000 (17:01 +0900)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Sun, 22 Mar 2020 20:47:58 +0000 (16:47 -0400)
commit39f1dbb060413d3eca8a702e75d75ce85fdaacc1
treea644b130b68252f95d1f2203c9aa08dc395ab563
parent473a9d8a6410c114d3ffc6f9fae891109a379fe7
NFS: direct.c: Fix memory leak of dreq when nfs_get_lock_context fails

When dreq is allocated by nfs_direct_req_alloc(), dreq->kref is
initialized to 2. Therefore we need to call nfs_direct_req_release()
twice to release the allocated dreq. Usually it is called in
nfs_file_direct_{read, write}() and nfs_direct_complete().

However, current code only calls nfs_direct_req_relese() once if
nfs_get_lock_context() fails in nfs_file_direct_{read, write}().
So, that case would result in memory leak.

Fix this by adding the missing call.

Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/direct.c