]> git.baikalelectronics.ru Git - kernel.git/commit
gpio/aspeed-sgpio: don't enable all interrupts by default
authorJeremy Kerr <jk@codeconstruct.com.au>
Fri, 11 Sep 2020 01:51:05 +0000 (09:51 +0800)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Thu, 24 Sep 2020 13:10:56 +0000 (15:10 +0200)
commit39bc86db3803492d1803083747e89b1865ae9e49
tree69e8e9d46fc90eebf204859594bb67d0fb1aae79
parentf902e56e5c2437c93543e2fc032b5004ec8c1998
gpio/aspeed-sgpio: don't enable all interrupts by default

Currently, the IRQ setup for the SGPIO driver enables all interrupts in
dual-edge trigger mode. Since the default handler is handle_bad_irq, any
state change on input GPIOs will trigger bad IRQ warnings.

This change applies sensible IRQ defaults: single-edge trigger, and all
IRQs disabled.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Fixes: fe8e2fb5f64e ("gpio: aspeed: Add SGPIO driver")
Reviewed-by: Joel Stanley <joel@jms.id.au>
Acked-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-aspeed-sgpio.c