]> git.baikalelectronics.ru Git - kernel.git/commit
cifs: fix locking and list handling code in cifs_open and its helper
authorJeff Layton <jlayton@redhat.com>
Fri, 25 Sep 2009 13:53:37 +0000 (09:53 -0400)
committerSteve French <sfrench@us.ibm.com>
Fri, 25 Sep 2009 17:59:31 +0000 (17:59 +0000)
commit3991bf2b3eddecbefec23c5dbad4e90b1aa039d9
treecf349723b7b4f48151d10eeaeff322c05fd9de3b
parent5e0268e2a68e57a48a426c12d00b1aa681927868
cifs: fix locking and list handling code in cifs_open and its helper

The patch to remove cifs_init_private introduced a locking imbalance. It
didn't remove the leftover list addition code and the unlocking in that
function. cifs_new_fileinfo does the list addition now, so there should
be no need to do it outside of that function.

pCifsInode will never be NULL, so we don't need to check for that. This
patch also gets rid of the ugly locking and unlocking across function
calls.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/file.c