]> git.baikalelectronics.ru Git - kernel.git/commit
bnxt_en: fix memory leaks in bnxt_dcbnl_ieee_getets()
authorEdwin Peer <edwin.peer@broadcom.com>
Sun, 22 Mar 2020 20:40:02 +0000 (16:40 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Mar 2020 04:42:48 +0000 (21:42 -0700)
commit3935b82b17d8e7672d1ed412b57089635c487fea
tree575225b576777e853067e709cadfd8adf8008043
parent32d4f93968b2e4fb5d856cf010a7d963a8373062
bnxt_en: fix memory leaks in bnxt_dcbnl_ieee_getets()

The allocated ieee_ets structure goes out of scope without being freed,
leaking memory. Appropriate result codes should be returned so that
callers do not rely on invalid data passed by reference.

Also cache the ETS config retrieved from the device so that it doesn't
need to be freed. The balance of the code was clearly written with the
intent of having the results of querying the hardware cached in the
device structure. The commensurate store was evidently missed though.

Fixes: 894124331819 ("bnxt_en: Implement DCBNL to support host-based DCBX.")
Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c