]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: ufs: qcom: Add a readl() to make sure ref_clk gets enabled
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Wed, 4 May 2022 08:42:10 +0000 (14:12 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 11 May 2022 01:52:53 +0000 (21:52 -0400)
commit3906f7be15c66697a4b91ec4439ca9e8ffd3d9b3
tree9ae31901b0d8e8574ccd42e7071b400ad174ca8d
parentfde13568ca89881b617e1256321b1ac27299df14
scsi: ufs: qcom: Add a readl() to make sure ref_clk gets enabled

In ufs_qcom_dev_ref_clk_ctrl(), it was noted that the ref_clk needs to be
stable for at least 1us. Even though there is wmb() to make sure the write
gets "completed", there is no guarantee that the write actually reached the
UFS device. There is a good chance that the write could be stored in a
Write Buffer (WB). In that case, even though the CPU waits for 1us, the
ref_clk might not be stable for that period.

So lets do a readl() to make sure that the previous write has reached the
UFS device before udelay().

Also, the wmb() after writel_relaxed() is not really needed. Both writel()
and readl() are ordered on all architectures and the CPU won't speculate
instructions after readl() due to the in-built control dependency with read
value on weakly ordered architectures. So it can be safely removed.

Link: https://lore.kernel.org/r/20220504084212.11605-4-manivannan.sadhasivam@linaro.org
Fixes: cd40d3be913c ("scsi: ufs-qcom: add QUniPro hardware support and power optimizations")
Cc: stable@vger.kernel.org
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufs-qcom.c