]> git.baikalelectronics.ru Git - kernel.git/commit
drm/fb-helper: don't sleep for screen unblank when an oops is in progress
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 13 Sep 2013 21:49:57 +0000 (14:49 -0700)
committerDave Airlie <airlied@redhat.com>
Thu, 19 Sep 2013 01:54:34 +0000 (11:54 +1000)
commit38f6a7f8426be69d6224fd69a6f0a44c1925f0e5
treeac885b03ae981679ddc48ed6d763c6080e8ef62a
parent313913b49aa6d821e1e814bef0e1c7f3fad0b942
drm/fb-helper: don't sleep for screen unblank when an oops is in progress

Otherwise the system will burn even brighter and worse, leave the user
wondering what's going on exactly.

Since we already have a panic handler which will (try) to restore the
entire fbdev console mode, we can just bail out.  Inspired by a patch from
Konstantin Khlebnikov.  The callchain leading to this, cut&pasted from
Konstantin's original patch:

callstack:
panic()
bust_spinlocks(1)
unblank_screen()
vc->vc_sw->con_blank()
fbcon_blank()
fb_blank()
info->fbops->fb_blank()
drm_fb_helper_blank()
drm_fb_helper_dpms()
drm_modeset_lock_all()
mutex_lock(&dev->mode_config.mutex)

Note that the entire locking in the fb helper around panic/sysrq and kdbg
is ...  non-existant.  So we have a decent change of blowing up
everything.  But since reworking this ties in with funny concepts like the
fbdev notifier chain or the impressive things which happen around
console_lock while oopsing, I'll leave that as an exercise for braver
souls than me.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Dave Airlie <airlied@gmail.com>
Reviewed-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_fb_helper.c