]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "net: init sk_cookie for inet socket"
authorYafang Shao <laoar.shao@gmail.com>
Tue, 24 Apr 2018 15:07:45 +0000 (23:07 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Apr 2018 15:15:32 +0000 (11:15 -0400)
commit3895db62d5e9f829e55c9298baf4e870be3b2fe0
tree8ed0839695d99367f1e75dc1968c422b91a340c6
parent5f3e03920f008ca9f57981fea4848f74e19b0b3a
Revert "net: init sk_cookie for inet socket"

This reverts commit <f5a9a625a98c> ("net: init sk_cookie for inet socket")

Per discussion with Eric, when update sock_net(sk)->cookie_gen, the
whole cache cache line will be invalidated, as this cache line is shared
with all cpus, that may cause great performace hit.

Bellow is the data form Eric.
"Performance is reduced from ~5 Mpps to ~3.8 Mpps with 16 RX queues on
my host" when running synflood test.

Have to revert it to prevent from cache line false sharing.

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/sock_diag.h
net/ipv4/tcp_input.c