]> git.baikalelectronics.ru Git - kernel.git/commit
can: gs_usb: gs_can_start_xmit(): zero-initialize hf->{flags,reserved}
authorBrian Silverman <brian.silverman@bluerivertech.com>
Thu, 6 Jan 2022 00:29:50 +0000 (16:29 -0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sun, 9 Jan 2022 12:32:28 +0000 (13:32 +0100)
commit388a72793b88e3898af739e34e67bdc99aedddfb
tree6094e6e5c3cc7043256e47bd3a805f9959f5b8f5
parent36f77e18d4b7f77dd4b76d351c84035f1d925a3e
can: gs_usb: gs_can_start_xmit(): zero-initialize hf->{flags,reserved}

No information is deliberately sent in hf->flags in host -> device
communications, but the open-source candleLight firmware echoes it
back, which can result in the GS_CAN_FLAG_OVERFLOW flag being set and
generating spurious ERRORFRAMEs.

While there also initialize the reserved member with 0.

Fixes: f619109f865f ("can: gs_usb: Added support for the GS_USB CAN devices")
Link: https://lore.kernel.org/all/20220106002952.25883-1-brian.silverman@bluerivertech.com
Link: https://github.com/candle-usb/candleLight_fw/issues/87
Cc: stable@vger.kernel.org
Signed-off-by: Brian Silverman <brian.silverman@bluerivertech.com>
[mkl: initialize the reserved member, too]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/gs_usb.c