]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "PCI: Remove from bus_list and release resources in pci_release_dev()"
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sat, 1 Feb 2014 14:38:29 +0000 (15:38 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 1 Feb 2014 18:24:31 +0000 (10:24 -0800)
commit37daf5d191ef0fa763f53a79fee3ad1ca180552c
treea8a9806a3f55f5343b6375743c8e107e800c6df6
parentb9ae9ded879a23a5b1d44054f7da02d26135aeaa
Revert "PCI: Remove from bus_list and release resources in pci_release_dev()"

Revert commit 75057b37e5db "PCI: Remove from bus_list and release
resources in pci_release_dev()" that made some nasty race conditions
become possible.  For example, if a Thunderbolt link is unplugged
and then replugged immediately, the pci_release_dev() resulting from
the hot-remove code path may be racing with the hot-add code path
which after that commit causes various kinds of breakage to happen
(up to and including a hard crash of the whole system).

Moreover, the problem that commit 75057b37e5db attempted to address
cannot happen any more after commit 2374418ce3f3 "PCI: Check parent
kobject in pci_destroy_dev()", because pci_destroy_dev() will now
return immediately if it has already been executed for the given
device.

Note, however, that the invocation of msi_remove_pci_irq_vectors()
removed by commit 75057b37e5db from pci_free_resources() along with
the other changes made by it is not added back because of subsequent
code changes depending on that modification.

Fixes: 75057b37e5db (PCI: Remove from bus_list and release resources in pci_release_dev())
Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/pci/probe.c
drivers/pci/remove.c