]> git.baikalelectronics.ru Git - kernel.git/commit
tcp: fix bug in listening_get_next()
authorEric Dumazet <eric.dumazet@gmail.com>
Mon, 24 Jan 2011 22:41:20 +0000 (14:41 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Jan 2011 22:41:20 +0000 (14:41 -0800)
commit3798127aed79d5bbc01bf7cb12e1cf0eed18eb12
treee13f583f7848dcc1c620f3e4598e22f96a2d8efc
parent0977e5e48c9013dc0a11874137f23fbf2dbd0392
tcp: fix bug in listening_get_next()

commit ec4e56c39b2216845 (tcp: Fix slowness in read /proc/net/tcp)
introduced a bug in handling of SYN_RECV sockets.

st->offset represents number of sockets found since beginning of
listening_hash[st->bucket].

We should not reset st->offset when iterating through
syn_table[st->sbucket], or else if more than ~25 sockets (if
PAGE_SIZE=4096) are in SYN_RECV state, we exit from listening_get_next()
with a too small st->offset

Next time we enter tcp_seek_last_pos(), we are not able to seek past
already found sockets.

Reported-by: PK <runningdoglackey@yahoo.com>
CC: Tom Herbert <therbert@google.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_ipv4.c