]> git.baikalelectronics.ru Git - kernel.git/commit
remoteproc: avoid stack overflow in debugfs file
authorArnd Bergmann <arnd@arndb.de>
Fri, 20 Nov 2015 17:26:07 +0000 (18:26 +0100)
committerOhad Ben-Cohen <ohad@wizery.com>
Thu, 26 Nov 2015 08:07:53 +0000 (10:07 +0200)
commit37842712268d5cb3908cfed82d37d887cbee5529
tree3e35802656103fb2b4671e660c8dbdadf62066cd
parent1d37f22c117701709b102005124f4747fab5d517
remoteproc: avoid stack overflow in debugfs file

Recent gcc versions warn about reading from a negative offset of
an on-stack array:

drivers/remoteproc/remoteproc_debugfs.c: In function 'rproc_recovery_write':
drivers/remoteproc/remoteproc_debugfs.c:167:9: warning: 'buf[4294967295u]' may be used uninitialized in this function [-Wmaybe-uninitialized]

I don't see anything in sys_write() that prevents us from
being called with a zero 'count' argument, so we should
add an extra check in rproc_recovery_write() to prevent the
access and avoid the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: f113233c582d ("remoteproc: create a 'recovery' debugfs entry")
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
drivers/remoteproc/remoteproc_debugfs.c